Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapped horizontal legends height computations #3446

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

etpinard
Copy link
Contributor

fixes #3175

@Braintelligence off this branch, the two codepens from #3175 (comment), now look like:

which appear 馃憣 to my 馃憖

cc @plotly/plotly_js

@antoinerg
Copy link
Contributor

It does look good to my 馃憖 too! Thanks for the fix @etpinard and @Braintelligence.

馃拑

@etpinard etpinard merged commit 0251a0c into master Jan 21, 2019
@etpinard etpinard deleted the horiz-legend-wrap-all-lines-fix branch January 21, 2019 21:24
@Braintelligence
Copy link

@antoinerg I didn't do anything :p all kudos to master @etpinard

@Braintelligence
Copy link

Braintelligence commented Jan 22, 2019

@etpinard I'm gonna use the intermediary plotly.min.js you've created forfrom the codepen until a release containing the fix is available if that's alright with you 馃樃.

@etpinard
Copy link
Contributor Author

until a release containing the fix is available if that's alright with you

1.44.0 should be released today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Horizontal Legend Wrapping doesn't account properly for usage of <br> tags
3 participants