Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear subplotType cache on Plotly.register() #3448

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Clear subplotType cache on Plotly.register() #3448

merged 1 commit into from
Jan 22, 2019

Conversation

etpinard
Copy link
Contributor

fixes #3428

cc @plotly/plotly_js

@etpinard
clear subplotType cache on Plotly.register()
8db005d 
... so that new subplot types can be dynamically imported.
@antoinerg
Copy link
Contributor

Nice tests 👍: this is ready 💃

@etpinard etpinard merged commit 3b9188d into master Jan 22, 2019
@etpinard etpinard deleted the fix-dynamic-imports branch January 22, 2019 01:53
@dan8f
Copy link
Contributor

dan8f commented Jan 22, 2019

👍 thanks @etpinard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: reviewable type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plots.supplyDeffaults subplot type cache doesn't allow dynamic trace module imports
3 participants
@etpinard @antoinerg @dan8f