Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear _inputDomain on cartesian axes with altered domains #3461

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@etpinard
Copy link
Member

etpinard commented Jan 22, 2019

... during Plotly.react diffing - fixes #3430

See now bug-free codepen: https://codepen.io/etpinard/pen/EraKjq

cc @plotly/plotly_js

clear _inputDomain on cartesian axes with altered domains
... during Plotly.react diffing.
@@ -2954,6 +2954,11 @@ function getDiffFlags(oldContainer, newContainer, outerparts, opts) {
flags.rangesAltered[outerparts[0]] = 1;
}

// clear _inputDomain on cartesian axes with altered domains
if(AX_DOMAIN_RE.test(astr)) {
nestedProperty(newContainer, '_inputDomain').set(null);

This comment has been minimized.

Copy link
@etpinard

etpinard Jan 22, 2019

Author Member

This piece is the react equivalent to this block

else if(pleafPlus.match(AX_DOMAIN_RE)) {
nestedProperty(fullLayout, ptrunk + '._inputDomain').set(null);
}

called during relayout.

@antoinerg

This comment has been minimized.

Copy link
Collaborator

antoinerg commented Jan 22, 2019

Looks good to me! Nice fix 👌

@antoinerg

This comment has been minimized.

Copy link
Collaborator

antoinerg commented Jan 22, 2019

💃

@etpinard etpinard merged commit 8bdbf73 into master Jan 23, 2019

8 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: publish Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@etpinard etpinard deleted the fix-react-scaleanchor-domain-diff branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.