Add surfacecolor functionality to surface traces
#347
Conversation
- so that Plotly.restyle is also kept backward compatible.
- straight as 'intensityBounds' in 'surfacecolor' case - scaled by scaleFactor in 'z' case
|
|
||
| function mapLegacy(traceIn, oldAttr, newAttr) { | ||
| if(oldAttr in traceIn && !(newAttr in traceIn)) { | ||
| traceIn[newAttr] = traceIn[oldAttr]; |
There was a problem hiding this comment.
@mdtusz @cldougl @chriddyp Are you ok with this way of preserving backward compatibility?
zmin, zmax and zauto are deprecated in favour of cmin, cmax and cauto for surface traces.
The deprecated z attributes are mapped to their corresponding c attributes in the defaults step so that both plot and restyle call update the trace objects to the c attributes.
If both a c and z attribute are present, only the c attribute is coerced.
There was a problem hiding this comment.
Yep I'm ok with this. Ideally we would/should be able to remove the oldAttr from traceIn as well, but I imagine that may cause problems if there are other components that make use of it somewhere still.
There was a problem hiding this comment.
but I imagine that may cause problems if there are other components that make use of it somewhere still.
Exactly. That's why I took the conservative route here. We'll clean this up in v2.0.0 🎉 .
| zmax: colorscaleAttrs.zmax, | ||
| surfacecolor: { | ||
| valType: 'data_array', | ||
| description: [ |
There was a problem hiding this comment.
Can we have a more descriptive description? I'm still a little unclear on how this is used.
|
💃 from me. |
|
nice image test 🌈 |
Add `surfacecolor` functionality to surface traces
resolves #308
@mdtusz @mikolalysenko
This PR coupled with gl-vis/gl-surface3d#7 take the work started in #314 to the finish line.