Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isosurface opacity #3545

Merged
merged 13 commits into from Feb 18, 2019

Conversation

Projects
None yet
2 participants
@archmoj
Copy link
Collaborator

archmoj commented Feb 15, 2019

This PR enables opacity attribute for isosurface traces.
Also it addressed bug #3546 and removed the second drawings to find the edges see here.

In addition some improvements such as reduction of tolerance (to remove glitch in mesh generation #3547) are made in this PR. Various functions now return true or false result in case triangles are generated. This information is stored in the first pass & could be used in second pass processes.

This PR would be helpful for the volume PR #3488.
@plotly/plotly_js

Before codepen.
After codepen.

@archmoj archmoj added the type: bug label Feb 15, 2019

@etpinard

This comment has been minimized.

Copy link
Member

etpinard commented Feb 15, 2019

@archmoj Is this one ready to review?

@@ -235,10 +235,11 @@ colorscaleAttrs('', {

colorbar: colorbarAttrs,

contour: meshAttrs.contour,
opacity: meshAttrs.opacity,

This comment has been minimized.

Copy link
@etpinard

etpinard Feb 15, 2019

Member

We should probably point out in the mesh3d attributes that the current behavior isn't perfect and may be subject to change in the (near) future cc #3243

@archmoj

This comment has been minimized.

Copy link
Collaborator Author

archmoj commented Feb 15, 2019

@archmoj Is this one ready to review?

Yes please. @etpinard I thank you in advance!

@etpinard

This comment has been minimized.

Copy link
Member

etpinard commented Feb 15, 2019

Looks good!

#3545 (comment) is my only comment.

@etpinard etpinard added this to the v1.45.0 milestone Feb 15, 2019

@archmoj

This comment has been minimized.

Copy link
Collaborator Author

archmoj commented Feb 16, 2019

Looks good!

#3545 (comment) is my only comment.

@etpinard Thanks for the review.
In respect to your comment, it is done in abc8ae2.

@etpinard

This comment has been minimized.

Copy link
Member

etpinard commented Feb 18, 2019

Thanks @archmoj !

💃

@archmoj archmoj merged commit 0714286 into master Feb 18, 2019

8 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: publish Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@archmoj archmoj deleted the isosurface-opacity branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.