Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support locales in hovertemplate #3586

Merged
merged 3 commits into from
Feb 27, 2019
Merged

support locales in hovertemplate #3586

merged 3 commits into from
Feb 27, 2019

Conversation

antoinerg
Copy link
Contributor

This PR closes #3580

alexcjohnson
alexcjohnson reviewed Feb 27, 2019
View reviewed changes
src/lib/index.js Outdated Show resolved Hide resolved
alexcjohnson
alexcjohnson approved these changes Feb 27, 2019
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💃
Great tests, though a French locale using pounds is a little funny 😏

@antoinerg antoinerg merged commit 4877a9c into master Feb 27, 2019
@antoinerg antoinerg deleted the fix-3580 branch February 27, 2019 23:14
@archmoj archmoj mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
status: reviewable type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hovertemplate d3-format numbers ignoring locale
3 participants
@antoinerg @alexcjohnson @etpinard