Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gl3d orthographic zoom using mouse scroll wheel #3601

Merged
merged 3 commits into from Mar 20, 2019
Merged

Gl3d orthographic zoom using mouse scroll wheel #3601

merged 3 commits into from Mar 20, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Mar 4, 2019

May fix #3588.
In orthographic projection, mouse scroll wheel could scale scene instead of panning camera on the z axis.
Zoom modebar button on the other hand can be used to adjust near clipping.
Codepen.
@plotly/plotly_js

package.json Outdated
@@ -80,7 +80,7 @@
"gl-mat4": "^1.2.0",
"gl-mesh3d": "^2.0.8",
"gl-plot2d": "^1.4.2",
"gl-plot3d": "^2.1.1",
"gl-plot3d": "git://github.com/gl-vis/gl-plot3d.git#1e3ee374f079e4e00205740b414634b7fdff4c70",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etpinard
Copy link
Contributor

etpinard commented Mar 6, 2019

Cool. Let's tag this under 1.46.0

@etpinard etpinard added this to the v1.46.0 milestone Mar 6, 2019
@etpinard
Copy link
Contributor

Looks good to me. 💃 after bumping gl-plot3d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot zoom when the new orthographic projection mode is used
2 participants