Fix avoid-overlap hover label algo when "too close" label get filtered out #3645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3603
before: https://codepen.io/antoinerg/pen/MxEjeo
after: https://codepen.io/etpinard/pen/LaBpYm
In this example, we enter this block:
plotly.js/src/components/fx/hover.js
Lines 872 to 877 in fc236e2
where
hoverData
gets filtered down showing two visible hover labels, but isn't updated for the downstreamhoverAvoidOverlaps
call where the "old" (longer)hoverData
array is used here:plotly.js/src/components/fx/hover.js
Lines 1099 to 1114 in fc236e2
cc @plotly/plotly_js