Skip to content

Rearrange jasmine test retries #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 1, 2019
Merged

Rearrange jasmine test retries #3667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
34158c1
using different retry numbers for gl and flaky containers
archmoj Mar 22, 2019
c57d316
moved gl2d double-click into another file
archmoj Mar 24, 2019
5395282
Merge remote-tracking branch 'origin/master' into reduce-num-retries-…
archmoj Mar 29, 2019
8241bc8
reduced retries to 2 and 3 - marked one test as flaky
archmoj Mar 29, 2019
230544f
no foreach may help run the CI
archmoj Mar 29, 2019
17b5068
should reset one sankey test - no need to flaky flag as it fails loca…
archmoj Mar 29, 2019
4b0b824
Merge remote-tracking branch 'origin/master' into reduce-num-retries-…
archmoj Apr 1, 2019
305e0b3
set flaky retry number to 4 - before rerun 10 times
archmoj Apr 1, 2019
24aafc8
Apply Etienne recommendations
archmoj Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .circleci/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ case $1 in
set_tz

SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=gl | circleci tests split))

for s in ${SHARDS[@]}; do
retry npm run test-jasmine -- "$s" --tags=gl --skip-tags=noCI --showSkipped
done
Expand All @@ -65,7 +64,7 @@ case $1 in
jasmine3)
set_tz

SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=flaky | circleci tests split))
SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --limit=1 --tag=flaky | circleci tests split))

for s in ${SHARDS[@]}; do
retry npm run test-jasmine -- "$s" --tags=flaky --skip-tags=noCI --showSkipped
Expand Down
Loading