ensure we create only one modebar-container
#3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinerg
commented
Mar 25, 2019
src/plot_api/plot_api.js
Outdated
| @@ -3802,6 +3802,7 @@ function makePlotFramework(gd) { | |||
| .classed('gl-container', true); | |||
|
|
|||
| fullLayout._paperdiv.selectAll('.main-svg').remove(); | |||
| fullLayout._paperdiv.selectAll('.modebar-container').remove(); | |||
There was a problem hiding this comment.
We remove the existing modebar because:
plotly.js/src/plot_api/plot_api.js
Lines 3792 to 3796 in 3e9d162
etpinard
reviewed
Mar 25, 2019
src/plot_api/plot_api.js
Outdated
| @@ -3802,6 +3802,7 @@ function makePlotFramework(gd) { | |||
| .classed('gl-container', true); | |||
|
|
|||
| fullLayout._paperdiv.selectAll('.main-svg').remove(); | |||
| fullLayout._paperdiv.selectAll('.modebar-container').remove(); | |||
There was a problem hiding this comment.
.select should suffice here, as there's only one <div.modebar-container> per graph.
etpinard
reviewed
Mar 25, 2019
| expect(hoverlayer.length).toBe(1); | ||
|
|
||
| var compareMask = infolayer[0].compareDocumentPosition(modebar[0]); | ||
| expect(compareMask).toBe(Node.DOCUMENT_POSITION_FOLLOWING, '.modebar-container appears after the .infolayer'); |
There was a problem hiding this comment.
Wow. I didn't know that thing existed. NICE!
There was a problem hiding this comment.
Me neither! Just found out about them today: https://developer.mozilla.org/en-US/docs/Web/API/Node/compareDocumentPosition 😄
|
Thanks for the quick fix 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3677