Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix colormap error for colorscales with length of 256 #3702

Merged
merged 2 commits into from Apr 2, 2019

Conversation

Projects
None yet
2 participants
@archmoj
Copy link
Collaborator

commented Apr 1, 2019

"requires": {
"binary-search-bounds": "^2.0.4",
"bit-twiddle": "^1.0.2",
"colormap": "^2.1.0",
"colormap": "git://github.com/archmoj/colormap.git#c8b31f77f88ba1160f30bcd6ba10753ca0ed0404",

This comment has been minimized.

Copy link
@archmoj

This comment has been minimized.

Copy link
@etpinard

etpinard Apr 1, 2019

Member

👌 can you make a PR there and ping @bpostlethwaite ?

@etpinard

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Nicely done!

💃 💃

@archmoj archmoj merged commit 32738b5 into master Apr 2, 2019

10 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: publish Your tests passed on CircleCI!
Details
ci/circleci: test-bundle Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine3 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@archmoj archmoj deleted the fix3699-colorscale256 branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.