Skip to content

Fix npm run test-image -- * for mock lists w/o gl2d_* mocks #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2019
Merged

Fix npm run test-image -- * for mock lists w/o gl2d_* mocks #3707

merged 1 commit into from
Apr 1, 2019

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Apr 1, 2019 •
edited
Loading

A follow-up of #3634

Currently on master:

npm run test-image -- 10

gives us:

image

as we're trying to sort ['gl2d_pointcloud-basic', 'gl2d_heatmapgl'] to the front even though they're not in the list of mocks we're trying to test.

cc @plotly/plotly_js

@archmoj
Copy link
Contributor

archmoj commented Apr 1, 2019

Thanks for the fix.
💃

@etpinard etpinard merged commit 7b96c41 into master Apr 1, 2019
@etpinard etpinard deleted the fix-npm-run-test-image branch April 1, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etpinard @archmoj