Draw box/violin pts as legend item when other parts have opacity 0 #3846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
commented
May 8, 2019
|
|
||
| p.style('stroke-width', w + 'px') | ||
| .call(Color.fill, trace.fillcolor); | ||
| if((trace.boxpoints === 'all' || trace.points === 'all') && |
There was a problem hiding this comment.
@nicolaskruchten do you use other (box)points values for your px strip traces?
If so, we might need to add logic for marker.outliercolor, marker.line.outliercolor and marker.line.outlierwidth in the block below.
There was a problem hiding this comment.
might be interesting to add a mode where we show all points but style [suspected]outliers differently - but currently these other modes both hide the non-outlier points entirely - which seems like an awfully bad idea to combine with hiding the box/violin!
There was a problem hiding this comment.
for px I was planning on using 'all', because of @alexcjohnson's comment :) so this is looking great to me :)
|
Looks good to me 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3836
before: https://codepen.io/etpinard/pen/pmjGEL?editors=0010
after: https://codepen.io/MojtabaSamimi/pen/JqYQjG?editors=0010
cc @plotly/plotly_js @nicolaskruchten