Fix hoverAvoidOverlaps for zoomed-in violin traces #3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that hoverAvoirOverlaps in Fx.hover can do its job
properly.
etpinard
commented
May 22, 2019
| fig.layout.width = 700; | ||
| fig.layout.height = 450; | ||
|
|
||
| Plotly.plot(gd, fig) |
There was a problem hiding this comment.
I couldn't reproduce the bug using a simpler mock, so I added the data/layout used in https://codepen.io/etpinard/pen/wberrP?editors=1010 as a mock.
This test here currently yields
on master.
|
Nice fix @etpinard 💃 |
This was referenced Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ##3875
before: https://codepen.io/etpinard/pen/wberrP?editors=1010
after: https://codepen.io/etpinard/pen/NVXEOw?editors=1010
cc @plotly/plotly_js