Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial zh-CN translation based on ja.js dictionary strings #4276

Merged
merged 7 commits into from Oct 28, 2019

Conversation

@boltomli
Copy link
Contributor

boltomli commented Oct 14, 2019

Thanks for your interest in plotly.js!

Translations:

  • Make a PR directly to the main repository
  • Please @ mention a few other speakers of this language who can help review your translations.
  • If you've omitted any keys from dist/translation_keys.txt - which means they will fall back on the US English text - just make a short comment about why in the PR description: the English text works fine in your language, or you would like someone else to help translating those, or whatever the reason.
  • You should only update files in lib/locales/, not those in dist/

Features, Bug fixes, and others:

Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.

Before opening a pull request, developer should:

  • git rebase their local branch off the latest master,
  • make sure to not git add the dist/ folder (the dist/ is updated only on version bumps),
  • make sure to commit changes to the package-lock.json file (if any),
  • write an overview of what the PR attempts to do,
  • select the Allow edits from maintainers option (see this article for more details).

Note that it is forbidden to force push (i.e. git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please git merge master into your PR branch instead of git rebase master.

@etpinard

This comment has been minimized.

Copy link
Member

etpinard commented Oct 15, 2019

Thanks very much for the PR, can you now please @ mention a few other speakers of this language who can help review your translations?

@etpinard

This comment has been minimized.

Copy link
Member

etpinard commented Oct 23, 2019

Ping @boltomli - do you know any other Github users that are native speakers of zn-CN ?

@alexcjohnson

This comment has been minimized.

Copy link
Contributor

alexcjohnson commented Oct 24, 2019

Maybe @byronz could take a look?

@boltomli

This comment has been minimized.

Copy link
Contributor Author

boltomli commented Oct 24, 2019

@Sunshow might have time to check as well?

lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
boltomli and others added 2 commits Oct 25, 2019
Co-Authored-By: Byron Zhu <byronz@users.noreply.github.com>
Co-Authored-By: Byron Zhu <byronz@users.noreply.github.com>
boltomli and others added 3 commits Oct 25, 2019
Co-Authored-By: Byron Zhu <byronz@users.noreply.github.com>
Co-Authored-By: Byron Zhu <byronz@users.noreply.github.com>
lib/locales/zh-cn.js Outdated Show resolved Hide resolved
@etpinard etpinard added this to the v1.51.0 milestone Oct 25, 2019
@etpinard

This comment has been minimized.

Copy link
Member

etpinard commented Oct 28, 2019

Ok - test-syntax is still failing, since I don't have push rights to @boltomli 's branch I'll go ahead and merge this PR and make a fixup PR in the next few minutes.

@etpinard etpinard merged commit 7855ede into plotly:master Oct 28, 2019
7 of 9 checks passed
7 of 9 checks passed
ci/circleci: test-jasmine Your tests failed on CircleCI
Details
ci/circleci: test-syntax Your tests failed on CircleCI
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: publish Your tests passed on CircleCI!
Details
ci/circleci: test-bundle Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine3 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.