Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mapbox-gl to 1.9.1 #4752

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Bump mapbox-gl to 1.9.1 #4752

merged 2 commits into from
Apr 20, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 10, 2020

Maybe best to merge this in the next minor.

@plotly/plotly_js

@alexcjohnson
Copy link
Collaborator

Yes, this definitely deserves a minor, not a patch.

Does this impact any of the mapbox baselines? Those are in the @noCI tests, right?

Curious whether this would have addressed plotly/dash-core-components#756 and friends - hopefully we won't find out, and the underlying bug will never bubble up in this repo!

@archmoj archmoj added this to the v1.54.0 milestone Apr 10, 2020
@archmoj
Copy link
Contributor Author

archmoj commented Apr 10, 2020

Does this impact any of the mapbox baselines? Those are in the @noCI tests, right?

No change came to my eyes.
Maybe we could/should test this better.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you’ve run the noCI tests and you’re happy with what you saw, that’s fine. No need for more tests. 💃 (to be merged for a minor)

@archmoj archmoj merged commit 4b76edf into master Apr 20, 2020
@archmoj archmoj deleted the bump-mapbox-gl-april2020 branch April 20, 2020 15:28
@archmoj archmoj changed the title Bump mapbox-gl to 1.9.2 Bump mapbox-gl to 1.9.1 Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants