Skip to content

Fix contourgl supplyDefaults #4951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2020
Merged

Fix contourgl supplyDefaults #4951

merged 1 commit into from
Jun 24, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jun 24, 2020

Similar to #4950.
Attributesxcalendar & ycalendar used to be get into the fullData although they were not part of the contourgl API at the moment.

This PR fixes that and adds a test.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Jun 24, 2020
alexcjohnson
alexcjohnson approved these changes Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, good to have for parity, but I'm not really aware of anyone using contourgl - partly because it has a lot of deficiencies vs contour - so I don't think it's worth spending much time on.
💃

@archmoj archmoj merged commit 5c0179d into master Jun 24, 2020
@archmoj archmoj deleted the test-contourgl-coerce branch June 24, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson