Skip to content

Fix median transform aggregation #4969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2020
Merged

Fix median transform aggregation #4969

merged 1 commit into from
Jun 30, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jun 30, 2020

Fixes #4966 by using numeric sort function instaed of default.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Jun 30, 2020
alexcjohnson
alexcjohnson approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 JavaScript's default sort function is one of the most frustrating choices they made - especially since in many cases it does the right thing anyway so it can make you think you're safe.

@archmoj archmoj mentioned this pull request Jun 30, 2020
Merged
@archmoj archmoj merged commit b08d780 into master Jun 30, 2020
@archmoj archmoj deleted the fix4966-median-sort branch June 30, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plotly Transform Aggretation: median calculation appears wrong
2 participants
@archmoj @alexcjohnson