Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more sunburst rotation #5201

Merged
merged 3 commits into from Oct 11, 2020
Merged

more sunburst rotation #5201

merged 3 commits into from Oct 11, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 8, 2020 •
edited

Follow up merging #5171,
I noticed a bug in transition using new rotation attribute.
This PR fixes that. In addition fixes pie when rotation is set to auto see #5171 (comment) and adds an image test.

@plotly/plotly_js
cc: @thierryVergult

@archmoj archmoj added this to the v1.57.0 milestone Oct 8, 2020
alexcjohnson
alexcjohnson approved these changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Nice catch on the transition bug, that's a weird one! And thanks for the 'auto' fix.

@archmoj archmoj merged commit 8b76d46 into master Oct 11, 2020
@archmoj archmoj deleted the sunburst-rotation-tests branch October 11, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
status: reviewable type: bug type: feature
Projects
None yet
Milestone
v1.57.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@archmoj @alexcjohnson