Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull-request template #5220

Merged
merged 2 commits into from Oct 19, 2020
Merged

Update pull-request template #5220

merged 2 commits into from Oct 19, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 19, 2020

@plotly/plotly_js

- write an overview of what the PR attempts to do,
- make a PR directly from their fork to the main repository i.e. plotly/plotly.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just remove all mention of which copy of the repo to make a PR to - I think at this point it's standard practice to PR to the main one. So that would be removing this line, as well as line 5 re: translations.

Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 31955e7 into master Oct 19, 2020
@archmoj archmoj deleted the archmoj-patch-1 branch October 19, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants