Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary styling of backgrounds during automargin redraws when subplot positions are incomplete #5236

Merged
merged 1 commit into from Oct 28, 2020
Merged

Avoid unnecessary styling of backgrounds during automargin redraws when subplot positions are incomplete #5236

merged 1 commit into from Oct 28, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 27, 2020

Fixes #5235.

@plotly/plotly_js

alexcjohnson
alexcjohnson approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM, assuming the image test error is spurious. 💃

@archmoj archmoj changed the title Avoid unnecessary styling of backgrounds during automargin when subplot positions are incomplete Avoid unnecessary styling of backgrounds during automargin redraws when subplot positions are incomplete Oct 28, 2020
@archmoj archmoj merged commit 0fce11b into master Oct 28, 2020
@archmoj archmoj deleted the fix5235-guard-against-bad-coords branch October 28, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
status: reviewable type: bug type: regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SVG NaN errors when shapes and bgcolor are specified
2 participants
@archmoj @alexcjohnson