Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoverLabels: Check for <= 0 error values for log axes #533

Merged
merged 1 commit into from
May 13, 2016
Merged

Conversation

mdtusz
Copy link
Contributor

@mdtusz mdtusz commented May 13, 2016

Fixes #519.

Trying to find the true source of this issue became a tangled mess of function diving until your head spins, so this is a quick fix that will prevent NaN values from getting through as text labels.

@etpinard
Copy link
Contributor

Yeah. This is not the cleanest patch in the world. But, any patch in graph_interact.js will be messy. The added test cases is the most important part of this PR.

💃

@mdtusz mdtusz merged commit 5601e69 into master May 13, 2016
@mdtusz mdtusz deleted the nan-labels branch May 13, 2016 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero values on log axes appear as NaNs in hover labels
2 participants