Skip to content

Simplify autorange pipeline for inside ticklabels #5332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2020
Merged

Simplify autorange pipeline for inside ticklabels #5332

merged 1 commit into from
Dec 9, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Dec 9, 2020

As discovered in #5331 (comment), it appears there is no clear gain to keep padInsideLabelsOnThisAxis function which tweaks the axis range on both sides when inside ticklabelposition is used on the axis.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Dec 9, 2020
@archmoj archmoj requested a review from alexcjohnson December 9, 2020 21:56
alexcjohnson
alexcjohnson approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch - this is indeed better. 💃

@archmoj archmoj merged commit 4a3fc8e into master Dec 9, 2020
@archmoj archmoj deleted the improve-inside-ticklabel-autorange branch December 9, 2020 22:28
@archmoj archmoj added this to the NJK bucket list milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
NJK bucket list
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson