Skip to content

Avoid autoscale error with false autorange #5336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 11, 2020
Merged

Avoid autoscale error with false autorange #5336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
478d421
fix issue 5290 - check before slice
archmoj Dec 10, 2020
040dcd3
add jasmine test to lock issue 5290
archmoj Dec 11, 2020
ddc1c8a
Update test/jasmine/tests/axes_test.js
archmoj Dec 11, 2020
5dee4fc
Update test/jasmine/tests/axes_test.js
archmoj Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/plot_api/plot_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1948,7 +1948,9 @@ function axRangeSupplyDefaultsByPass(gd, flags, specs) {
var axIn = gd.layout[axName];
var axOut = fullLayout[axName];
axOut.autorange = axIn.autorange;
axOut.range = axIn.range.slice();
if(axIn.range) {
axOut.range = axIn.range.slice();
}
axOut.cleanRange();

if(axOut._matchGroup) {
Expand Down
50 changes: 50 additions & 0 deletions test/jasmine/tests/axes_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1433,6 +1433,56 @@ describe('Test axes', function() {
});
});

describe('autorange relayout', function() {
var gd;

beforeEach(function() {
gd = createGraphDiv();
});

afterEach(destroyGraphDiv);

it('can relayout autorange', function(done) {
Plotly.newPlot(gd, {
data: [{
x: [0, 1],
y: [0, 1]
}],
layout: {
width: 400,
height: 400,
margin: {
t: 40,
b: 40,
l: 40,
r: 40
},
xaxis: {
autorange: false,
},
yaxis: {
autorange: true,
}
}
}).then(function() {
expect(gd._fullLayout.xaxis.range).toEqual([-1, 6]);
expect(gd._fullLayout.yaxis.range).toBeCloseToArray([-0.07, 1.07]);

return Plotly.relayout(gd, 'yaxis.autorange', false);
}).then(function() {
expect(gd._fullLayout.yaxis.autorange).toBe(false);
expect(gd._fullLayout.yaxis.range).toBeCloseToArray([-0.07, 1.07]);

return Plotly.relayout(gd, 'xaxis.autorange', true);
}).then(function() {
expect(gd._fullLayout.xaxis.autorange).toBe(true);
expect(gd._fullLayout.xaxis.range).toBeCloseToArray([-0.07, 1.07]);
})
.catch(failTest)
.then(done);
});
});

describe('constraints relayout', function() {
var gd;

Expand Down