Skip to content

Cleanup unused r and t attributes from bar #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2021
Merged

Cleanup unused r and t attributes from bar #5408

merged 1 commit into from
Jan 15, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 15, 2021 •
edited
Loading

Followup of the cleanup in pull #5399, some unused attributes were found in the bar attributes.

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Jan 15, 2021
alexcjohnson
alexcjohnson approved these changes Jan 15, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 nice catch!

@archmoj archmoj changed the title Drop r and t attributes from the API of bar trace Cleanup unused r and t attributes from bar Jan 15, 2021
@archmoj archmoj merged commit 35cfbaf into master Jan 15, 2021
@archmoj archmoj deleted the drop-r-and-t-from-bar branch January 15, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson