Skip to content

Drop role key from attributes #5425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2021
Merged

Drop role key from attributes #5425

merged 4 commits into from
Jan 20, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 20, 2021

role appears to be unused and rather confusing to work with when writing new features.
cc: #5395

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Jan 20, 2021
@archmoj archmoj mentioned this pull request Jan 20, 2021
Merged
alexcjohnson
alexcjohnson approved these changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Look at all that 🔴 !! 🎉 🔪

@archmoj archmoj merged commit 2d801b4 into master Jan 20, 2021
@archmoj archmoj deleted the remove-role branch January 20, 2021 02:27
@nicolaskruchten
Copy link
Contributor

Hmmm upon further reflection, I think we should check with the R/Julia/.Net folks or whatever to see if they're using the role in the schema.

This was referenced Jan 22, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@archmoj @nicolaskruchten @alexcjohnson