Skip to content

reorder black list in mock test and add comments #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 38 additions & 33 deletions tasks/test_mock.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,44 @@ function assert(name, v) {

function notBlackListed(name) {
return [
// has transforms See https://github.com/plotly/plotly.js/issues/4759
'gl2d_transforms',
'polar_transforms',
'transforms',

// has contourcarpet See https://github.com/plotly/plotly.js/issues/5669
'airfoil',
'cheater',
'cheater_constraint_greater_than',
'cheater_constraint_greater_than_with_hill',
'cheater_constraint_greater_than_with_valley',
'cheater_constraint_inner_range',
'cheater_constraint_inner_range_hi_top',
'cheater_constraint_inner_range_hi_top_with_hill',
'cheater_constraint_inner_range_hi_top_with_valley',
'cheater_constraint_inner_range_lo_top',
'cheater_constraint_inner_range_lo_top_with_hill',
'cheater_constraint_inner_range_lo_top_with_valley',
'cheater_constraint_inner_range_with_hill',
'cheater_constraint_inner_range_with_valley',
'cheater_constraint_less_than',
'cheater_constraint_less_than_with_hill',
'cheater_constraint_less_than_with_valley',
'cheater_constraint_outer_range',
'cheater_constraint_outer_range_hi_top',
'cheater_constraint_outer_range_hi_top_with_hill',
'cheater_constraint_outer_range_hi_top_with_valley',
'cheater_constraint_outer_range_lo_top',
'cheater_constraint_outer_range_lo_top_with_hill',
'cheater_constraint_outer_range_lo_top_with_valley',
'cheater_constraint_outer_range_with_hill',
'cheater_constraint_outer_range_with_valley',
'cheater_constraints',
'cheater_contour',
'cheater_fully_filled',
'cheater_smooth',

// other
'1',
'11',
'12',
Expand All @@ -108,7 +146,6 @@ function notBlackListed(name) {
'32',
'2dhistogram_contour_subplots',
'2dhistogram_contour_subplots_bingroup',
'airfoil',
'annotations',
'annotations-autorange',
'axes_booleans',
Expand All @@ -122,35 +159,6 @@ function notBlackListed(name) {
'candlestick_double-y-axis',
'candlestick_rangeslider_thai',
'category-autorange',
'cheater',
'cheater_constraint_greater_than',
'cheater_constraint_greater_than_with_hill',
'cheater_constraint_greater_than_with_valley',
'cheater_constraint_inner_range',
'cheater_constraint_inner_range_hi_top',
'cheater_constraint_inner_range_hi_top_with_hill',
'cheater_constraint_inner_range_hi_top_with_valley',
'cheater_constraint_inner_range_lo_top',
'cheater_constraint_inner_range_lo_top_with_hill',
'cheater_constraint_inner_range_lo_top_with_valley',
'cheater_constraint_inner_range_with_hill',
'cheater_constraint_inner_range_with_valley',
'cheater_constraint_less_than',
'cheater_constraint_less_than_with_hill',
'cheater_constraint_less_than_with_valley',
'cheater_constraint_outer_range',
'cheater_constraint_outer_range_hi_top',
'cheater_constraint_outer_range_hi_top_with_hill',
'cheater_constraint_outer_range_hi_top_with_valley',
'cheater_constraint_outer_range_lo_top',
'cheater_constraint_outer_range_lo_top_with_hill',
'cheater_constraint_outer_range_lo_top_with_valley',
'cheater_constraint_outer_range_with_hill',
'cheater_constraint_outer_range_with_valley',
'cheater_constraints',
'cheater_contour',
'cheater_fully_filled',
'cheater_smooth',
'contour_match_edges',
'dendrogram',
'error_bar_style',
Expand Down Expand Up @@ -184,7 +192,6 @@ function notBlackListed(name) {
'gl2d_text_chart_single-string',
'gl2d_text_chart_styling',
'gl2d_texttemplate',
'gl2d_transforms',
'gl3d_autocolorscale',
'gl3d_bunny',
'gl3d_bunny-hull',
Expand Down Expand Up @@ -231,7 +238,6 @@ function notBlackListed(name) {
'plot_types',
'polar_blank',
'polar_dates',
'polar_transforms',
'range_slider_box',
'shapes_fixed_size',
'splom_ragged-via-axes',
Expand All @@ -245,7 +251,6 @@ function notBlackListed(name) {
'texttemplate_scatter',
'titles-avoid-labels',
'trace_metatext',
'transforms',
'updatemenus',
'violin_non-linear',
'violin_ridgeplot',
Expand Down