Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore stackgl node_modules folder when using npm pack #6008

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Ignore stackgl node_modules folder when using npm pack #6008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ce9e09
npm ignore stackgl node_modules folder
archmoj Nov 3, 2021
5624a9e
log for PR 6008
archmoj Nov 3, 2021
ad5b07f
do not include temporary draftlog folder in the package
archmoj Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@ build/*
!build/plotcss.js
!build/README.md

stackgl_modules/node_modules

devtools
test
draftlogs
dist/extras

circle.yml
Expand Down
1 change: 1 addition & 0 deletions draftlogs/6008_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix to avoid including local stackgl_modules/node_modules in the package (regression introduced in 2.6.0) [[#6008](https://github.com/plotly/plotly.js/pull/6008)]