use middle gray instead of 777 for default parcoords unselected line color
#6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's our default trace color set, not really any statement about what's the "ideal" or "official" gray color. We can adopt it if you think it's better that way, but I wouldn't consider the current color a bug :) |
The lightness value of 777 (777777) is 0.46 not 0.5 which may not be perfect with some background colors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6216 exposed parcoords'
deselectedLineColorconstant which was set to color: 777 which is euqal to 777777.However it would be best to set the
dfltfor this unreleased new attribute to7f7f7fwhich is our middle gray:plotly.js/src/components/color/attributes.js
Line 13 in b2df371
@plotly/plotly_js