Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mapbox shift select regression #6258

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Fix mapbox shift select regression #6258

merged 4 commits into from
Jul 14, 2022

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 14, 2022

Fixes a regression introduced by #6243.
With some other code improvements & cleanups.

@plotly/plotly_js

alexcjohnson
alexcjohnson approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Nice and clean, good catch with the map subplots!

@archmoj archmoj merged commit 3c511d2 into master Jul 14, 2022
@archmoj archmoj deleted the selections-patch-0 branch July 14, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@archmoj @alexcjohnson