Fix library's imported name using requirejs AMD loader

[archmoj]

Potential fix discovered by @alexcjohnson for AMD require in the docs

@plotly/plotly_js

[alexcjohnson]

Sure enough, in the unminified bundle I see define([], factory); like we had previously with browserify rather than the define('Plotly', [], factory); it had in the previous webpack build. So I expect this will work, but how hard would it be to test it in the actual docs pipeline? @nicolaskruchten ?

After define there are still some different code paths between the two headers, but the only other one I'm aware of that we care about is setting window.Plotly and they both do that - browserify by explicitly looking for window, webpack by setting self.Plotly and assuming self===window.

BTW, the link above was from the artifacts tab of the circleci job, if I go to the "Show URLs to Build Files" step instead the links (like https://176356-45646037-gh.circle-artifacts.com/0/dist/plotly.js) don't work.

[nicolaskruchten]

you can just test it with a requirejs snippet I think...

<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.2/require.js"></script> to load it, then

<script type="text/javascript">
window.PlotlyConfig = {MathJaxConfig: 'local'};
if (window.MathJax && window.MathJax.Hub && window.MathJax.Hub.Config) {window.MathJax.Hub.Config({SVG: {font: "STIX-Web"}});}
if (typeof require !== 'undefined') {
require.undef("plotly");
requirejs.config({
    paths: {
        'plotly': ['https://cdn.plot.ly/plotly-2.16.1.min']
    }
});
require(['plotly'], function(Plotly) {
    window._Plotly = Plotly;
});
}
</script>

to configure

then try something like require(["plotly"], function(Plotly) { Plotly.newPlot() } to see if it works? Maybe throw together a codepen with that and see? you'd have to point the configuration URL to a build artefact I think.

[archmoj]

Sure enough, in the unminified bundle I see define([], factory); like we had previously with browserify rather than the define('Plotly', [], factory); it had in the previous webpack build. So I expect this will work...

For reference here is the diff between before and after applying 16f1d1f.

[nicolaskruchten]

ok so here is a Pen with 2.16 https://codepen.io/nicolaskruchten/pen/zYLPGgY

here is a broken one with 2.17 https://codepen.io/nicolaskruchten/pen/NWBwGKL

here is one with the artifact from this branch (I think!) https://codepen.io/nicolaskruchten/pen/BaPmoax

[nicolaskruchten]

Generally it looks like it works?

[nicolaskruchten]

(I just lifted some bits of code from https://plotly.com/python/bar-charts/ so I'm fairly confident that this is representative of what goes on in py-docs)

[alexcjohnson]

💃 Excellent! Let's do it 🚀