Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x boundaries for ticksarray #6912

Merged
merged 4 commits into from Mar 1, 2024
Merged

Conversation

Farkites
Copy link
Contributor

@Farkites Farkites commented Mar 1, 2024

Reverted changes from #6885

Added x boundaries for axis with ticksmode = "array"

@Farkites Farkites marked this pull request as ready for review March 1, 2024 15:37
@archmoj
Copy link
Contributor

archmoj commented Mar 1, 2024

This is still work in progress, right?

@Farkites
Copy link
Contributor Author

Farkites commented Mar 1, 2024

This is still work in progress, right?

Yes! Let me change it to draft. Sorry about that!

@archmoj
Copy link
Contributor

archmoj commented Mar 1, 2024

No need to change it to draft. I actually prefer to have it like this.

@archmoj
Copy link
Contributor

archmoj commented Mar 1, 2024

This is a bug fix PR, right?

@archmoj
Copy link
Contributor

archmoj commented Mar 1, 2024

LGTM. Please add a draft log.

@archmoj
Copy link
Contributor

archmoj commented Mar 1, 2024

Nicely done.
💃

@Farkites Farkites merged commit 1087f73 into master Mar 1, 2024
1 check passed
@archmoj archmoj deleted the fix-tickson-boundaries-ticksarray branch March 15, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants