Skip to content

Fix scatterternary with ids attribute #7167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2024
Merged

Fix scatterternary with ids attribute #7167

merged 3 commits into from
Sep 20, 2024

Conversation

alexcjohnson
Copy link
Collaborator

Fix #7166

ids is part of the scatterternary schema, so it shouldn't break things! Anyway I want to use it for selection events, so I can reserve customdata for hover labels.

@alexcjohnson alexcjohnson changed the base branch from master to release-v2.35.3 September 20, 2024 20:17
@alexcjohnson alexcjohnson added the bug something broken label Sep 20, 2024
@archmoj
Copy link
Contributor

archmoj commented Sep 20, 2024

Thanks for the PR. 💃

@archmoj archmoj merged commit 22d8e85 into release-v2.35.3 Sep 20, 2024
1 check passed
@archmoj archmoj deleted the alex/ternary-ids branch September 20, 2024 21:07
Lexachoc referenced this pull request Nov 28, 2024
@archmoj
update changelog and readme for v3.0.0-rc.1
a143e3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@archmoj archmoj archmoj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ids attribute breaks scatterternary
2 participants
@alexcjohnson @archmoj