Fix subtitle does not properly clear/remove from the chart #7571
+5
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where
layout.title.subtitle
does not properly clear/remove from the chart whensubtitle
object is not in place, orsubtitle.text
set tonull
, empty string, or whitespace-only values viaPlotly.relayout()
.Problem
When users attempted to clear a subtitle using any of these methods:
The subtitle would remain visible on the chart. The only workaround was to set it to transparent:
Root Cause
In
src/components/titles/index.js
- Line 163: The conditionif(subtitleEnabled && subtitleElShouldExist)
prevented D3's.exit().remove()
from running when the subtitle needed to be cleared.Additional changes
subtitle.text
Notes
This follows the same D3 enter/exit pattern already used for the main title element (lines 147-157 in the same file).