Mapbox event triggers w/o duplication #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no need map mapbox opts to layout.mapbox and fire events at each step during the move, handling this at the end works just fine for our needs.
- 'moveend' (and 'movestart', 'move') gets triggered by map.setCenter, map.setZoom, map.setBearing and map.setPitch. - make sure that 'plotly_relayout' is triggered here only when the 'moveend' originates from a mouse target.
| @@ -658,6 +703,9 @@ describe('mapbox plots', function() { | |||
| }).then(function() { | |||
| return _mouseEvent('mousemove', p1, noop); | |||
| }).then(function() { | |||
| // repeat mousemove to simulate long dragging motion | |||
| return _mouseEvent('mousemove', p1, noop); | |||
|
Lgtm! 💃 |
etpinard
added a commit
that referenced
this pull request
Sep 8, 2016
Mapbox event triggers w/o duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapbox map API methods such as
map.setCenterandmap.setZoomtriggermove/movestartandmoveendevents on (see http://codepen.io/etpinard/pen/PGoyWO) - which in turn triggeredplotly_relayoutmultiple events per update.This PR cleans up the on-move logic:
'moveend'onlyplotly_relayoutis only trigger onmoveendoriginating from mouse interactions.