Sanitise gl2d double-click interactions #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this sanitizes double clicks interactions - e.g. double-click on the canvas now no longer puts the select-box in a weird state - see #744 for more info
etpinard
commented
Sep 21, 2016
| // disabling user select on the canvas | ||
| // sanitizes double-clicks interactions | ||
| // ref: https://github.com/plotly/plotly.js/issues/744 | ||
| canvas.className += 'user-select-none'; |
There was a problem hiding this comment.
@dfcreative I chose to add the 'user-select-none' class to the gl2d <canvas> nodes only to be safe - that way this patch won't affect the other plot types that use the gl-container div.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #744
Off this branch, double-clicking on the canvas now no longer puts the select-box in a weird state.
This solution was discovered by @dfcreative , I made a PR here to potential make this fix part of the
1.17.3patch release.