Skip to content

Accept proxy-related environment variables as lower or upper case #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Accept proxy-related environment variables as lower or upper case #1144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions plotly/plotly/chunked_requests/chunked_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,13 @@ def _get_proxy_config(self):
ssl_enabled = self._ssl_enabled

if ssl_enabled:
proxy = os.environ.get("https_proxy")
proxy = (os.environ.get("https_proxy") or
os.environ.get("HTTPS_PROXY"))
else:
proxy = os.environ.get("http_proxy")
no_proxy = os.environ.get("no_proxy")
proxy = (os.environ.get("http_proxy") or
os.environ.get("HTTP_PROXY"))

no_proxy = os.environ.get("no_proxy") or os.environ.get("NO_PROXY")
no_proxy_url = no_proxy and self._server in no_proxy

if proxy and not no_proxy_url:
Expand Down