Both username and key were being set improperly during test suite. #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should really refactor the test suite to prevent future unexpected events like this.
|
These passed locally now, but we'll wait to make sure they pass on Circle. I looked into the post params, it looks like username and key were being set in another test to ensure failure, but not being reset. This is a flaw in the test suite that should be addressed at some point. As a side note, we only check if keys exist in the credentials file, not if they're empty. A cursory check might save a user (and us!) a lot of hassle. I was debugging this and didn't realize I'd unset the file based on the errors i was getting back from _send_to_plotly: 500 Internal Server Error. |
|
yay! @etpinard , there's no problem with the library, just the test suite. I'll leave this for you to take a peek at and I'll merge tomorrow, no rush. |
|
Thanks man 👍 |
theengineear
added a commit
that referenced
this pull request
Sep 17, 2014
Both username and key were being set improperly during test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should really refactor the test suite to prevent future
unexpected events like this.