Currently, username matches are case SENSITIVE (not sure why). #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might as well make our tested usernames exact matches.
|
@etpinard , @chriddyp , this is to fix tests since usernames there are not exact case matches of plotly usernames. right now case-insensitive requests are being shut-down. This streambed PR is meant to fix that: https://github.com/plotly/streambed/pull/692 |
|
I'm going to go ahead and merge this in since it's only related to tests. |
theengineear
added a commit
that referenced
this pull request
Sep 24, 2014
Currently, username matches are case SENSITIVE (not sure why).
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might as well make our tested usernames exact matches.