Skip to content

Andrew flexible sign in #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 4, 2014
Merged

Andrew flexible sign in #134

merged 7 commits into from
Nov 4, 2014

Conversation

theengineear
Copy link
Contributor

Instead of being stuck with this:

py.sign_in('me', 'my_key')

you can now do:

py.sign_in('me', 'my_key', plotly_domain='my plotly', plotly_streaming_domain='my streaming')

This came up for development and testing. We should be able to change these per-session. We could hide all of this from the user, but i don't see the harm in exposing it.

@etpinard
Copy link
Contributor

+1

@theengineear
Copy link
Contributor Author

@chriddyp , this is related to the streaming_test i wrote today. It required messing with the user's local config, which might be troublesome for enterprise. (and the solution was a sloppy save/change/restore operation inside a thread...).

Hehe, looks like I already got the +1 from @etpinard , woohoo!

I'll probably just merge it in this case, but won't do a version bump unless we need it in the backend before you see this.

theengineear added a commit that referenced this pull request Nov 4, 2014
@theengineear theengineear merged commit 5761bcf into master Nov 4, 2014
@theengineear theengineear deleted the andrew-flexible-sign-in branch November 4, 2014 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants