Skip to content

Conversation

theengineear
Copy link
Contributor

There have been issues with the ssl certificate settings. Though this should be a last resort, these changes allow users to (a) set verify = False or (b) specifically define the certificate they are expecting.

Open issues:

  • do we need to do this for streaming?? the plotly.plotly.Stream object has no place for a 'verify', is that a different topic? i can't reproduce this error to check because my streaming cluster is down.

This can be:
- bool (True): always check
- bool (False): never check)
- str: (check certificate at specified path)
@theengineear
Copy link
Contributor Author

You config files can now include one of these ssl options:

'plotly_ssl_verification': true
'plotly_ssl_verification': false
'plotly_ssl_verification': '/absolute/path/to/file.crt'

@scjody , this seem alright? i thought it would be easiest for admins to stick an absolute path there? i also don't know why it would be so bad to leave this option as false since we're just talking to ourselves when we use this option...

@scjody
Copy link

scjody commented Nov 13, 2014

Looks good to me, but let's ask @bpostlethwaite about streaming.

I don't understand your comment about leaving the option as false. It should default to true (and it looks like that's what you did), so that we're secure by default (especially when talking to plot.ly).

@bpostlethwaite
Copy link
Member

Streaming runs over http

@scjody
Copy link

scjody commented Nov 13, 2014

💃 then 😸

@theengineear
Copy link
Contributor Author

sweet! good to go then!

theengineear added a commit that referenced this pull request Nov 13, 2014
@theengineear theengineear merged commit ea84183 into master Nov 13, 2014
@theengineear theengineear deleted the set-certificate branch November 13, 2014 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants