Fix IPython NB embed with custom width & height

[etpinard]

@theengineear @chriddyp

Custom iframe width & height are back !

Related Asana tasks here and here

[chriddyp]

cc @andrefarzat

One scenario we might want to consider is people who supplied width and height in their figure, but not in the iplot kwargs - we should be able to grab the width and height from the layout.

We should double check on these permutations:

iplot(fig) # default - 100% width, 650 or w/e height

fig['layout'] = Layout(width=500, height=500)
iplot(fig) # iframe's dimensions match the figure

iplot(fig, width=500, height=500) # the fig's autosize fills the iframe dimensions

fig['layout'] = Layout(width=200, height=300)
iplot(fig, width=500, height=500) # silly, fig is smaller than the iframe's dimensions

[theengineear]

@etpinard , nice!

@chriddyp , i like this idea, but it could serve as a separate PR yeah? then we can just commit this without the additional fuss?

[chriddyp]

Yeah totally. I think it's worth checkout the permutations - if someone sets the width and height of their figure, it should definitely show up that way in their iplot (it wasn't before)

[etpinard]

@theengineear thanks!

I'll merge this whenever you feel like bumping up the version.

[theengineear]

@etpinard , just merge it in and it will get swept into the next version bump! you could even push a new version to this branch and merge it in (that's probably a good idea). You don't have to push it to PyPI, but it might be good to have the version tracked in that way.

[chriddyp]

new version, new version!

Sent from my iPhone

On Nov 16, 2014, at 4:11 AM, Andrew notifications@github.com wrote:

@etpinard , just merge it in and it will get swept into the next version bump! you could even push a new version to this branch and merge it in (that's probably a good idea). You don't have to push it to PyPI, but it might be good to have the version tracked in that way.

—
Reply to this email directly or view it on GitHub.

[etpinard]

I won't be near my laptop today. Feel free to bump and merge this yourself

[andrefarzat]

@etpinard the iframe generated from this code doesn't match with the one generated by .html url. (e.g.: https://plot.ly/~chris/100.html ).

I dunno if this is too much work for a small thing, but it would be nice if the code makes a get request to its plot's .html url to get the most updated form of embed. Do you think it's doable ?

[etpinard]

@andrefarzat good idea.

But, for philosophical reasons, it seems weird to have plotly.tools.get_embed() make a request to Plotly for the latest .html representation of a plot.

cc @chriddyp @theengineear

[theengineear]

@etpinard , @andrefarzat , I think we should push this through and make a new issue for the other functionality. from me, a + 1 :)