Fix pandas serialization #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`to_json` was actually used by pandas, and was called by our json encoder before the correct pandas series json encoder was called
| @@ -35,7 +35,7 @@ def __str__(self): | |||
| def __repr__(self): | |||
| return 'Column("{}", {})'.format(self.data, self.name) | |||
|
|
|||
| def to_json(self): | |||
| def to_plotly_json(self): | |||
|
💃 once things are sorted out, hehe. |
|
Yeah man |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @theengineear @etpinard @msund