Remove plot.ly URL in exported HTML if user didn't enable link or sendToCloud #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to HTML export logic inspired by question in #1602. The HTML generated by
plotly.offline.plot/plotly.io.write_htmlis fully offline (no way to share data with cloud servers) by default. But even though the buttons/links to share data are disabled by default, the https://plot.ly URL was still included in the exported HTML.For peace of mind, this PR only includes the Chart Studio base URL (e.g. https://plot.ly) if the user overrides the defaults to turn on the
showLinkorsendToCloudconfig options.