Skip to content

Python3 bytes decoding fix #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 23, 2014
Merged

Python3 bytes decoding fix #169

merged 4 commits into from
Dec 23, 2014

Conversation

theengineear
Copy link
Contributor

An issue with escaping json saved in python 2 including patterns like:

'["\\"first param\\", second param"]'

@theengineear
Copy link
Contributor Author

@chriddyp , @etpinard , I had a rough time trying to test for this. I could only get a failing test case when I pulled that graph json data from our servers. Saving the json in python 2 and opening it in python 3 doesn't recreate the error... not sure why. I forked the original users' graph to a test user so we can make sure this doesn't happen again. Here's the original graph:

plot.ly/~reformthinktank/4

Note, this is only broken in python 3. Also, still waiting for tests to finish in circle.

//cc @msund

@etpinard
Copy link
Contributor

💃 nice catch

theengineear added a commit that referenced this pull request Dec 23, 2014
@theengineear theengineear merged commit d9b7cdc into master Dec 23, 2014
@theengineear theengineear deleted the python3-bytes-decoding-fix branch September 30, 2015 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants