Plotly Offline #236

chriddyp · 2015-06-25T05:57:53Z

No description provided.

etpinard · 2015-06-25T15:13:57Z

plotly/offline.py

+    res = requests.get(download_url + '/sourcefiles.json')
+    res.raise_for_status()
+
+    with open(os.path.join(plotlyjs_path, 'sourcefiles.json'), 'w') as f:


what are these sourcefiles.json ?

they contain the list of plotly.js dependencies:

{ "files": ["dependencies/d3.v3.min.js", "dependencies/jquery-latest.js", "dependencies/typedarray.js", "plotly.min.js"] }

that way, if we change the dependencies in the future we don't have to change anything on the python lib side. they just explain which files are necessary to include and to download

could this be a bundle we build in streambed and then a single download file for folks?

etpinard · 2015-06-25T15:19:33Z

This is the best thing that happen to IPython since IPython notebook.

chriddyp · 2015-06-25T22:19:03Z

please try it out and review @aneda @cldougl @theengineear ! thx!

chriddyp · 2015-06-25T22:28:47Z

@BRONSOLO @theengineear - did you guys change the folders endpoint on prod? this branch and master are failing in the test_duplicate_folders function.

theengineear · 2015-06-26T11:26:37Z

@chriddyp , it's a minor break, looks like ~~409~~ 400 for the particular issue. I just checked out api tests, the 400 is what we're currently expecting. Mind if we change this to a TestCase while we're in here : D ?:

"""
test_meta:
==========

A module intended for use with Nose.

"""
import random
import string
from unittest import TestCase

import plotly.plotly as py
from plotly.exceptions import PlotlyRequestError


class FolderAPITestCase(TestCase):

    def setUp(self):
        py.sign_in('PythonTest', '9v9f20pext')

    def _random_filename(self):
        random_chars = [random.choice(string.ascii_uppercase)
                        for _ in range(5)]
        unique_filename = 'Valid Folder'+''.join(random_chars)
        return unique_filename

    def test_create_folder(self):
        try:
            py.file_ops.mkdirs(self._random_filename())
        except PlotlyRequestError as e:
            self.fail('Expected this *not* to fail! Status: {}'
                      .format(e.status_code))

    def test_create_nested_folders(self):
        first_folder = self._random_filename()
        nested_folder = '{0}/{1}'.format(first_folder, self._random_filename())
        try:
            py.file_ops.mkdirs(nested_folder)
        except PlotlyRequestError as e:
            self.fail('Expected this *not* to fail! Status: {}'
                      .format(e.status_code))

    def test_duplicate_folders(self):
        first_folder = self._random_filename()
        py.file_ops.mkdirs(first_folder)
        try:
            py.file_ops.mkdirs(first_folder)
        except PlotlyRequestError as e:
            self.assertTrue(400 <= e.status_code < 500)
        else:
            self.fail('Expected this to fail!')

theengineear · 2015-06-26T11:29:35Z

This is the only reference to a 409 i can find:

https://github.com/plotly/python-api/blob/master/plotly/plotly/plotly.py#L774

I don't think the library is breaking because of this test :)

Also, I tested the above test changes in python 2.7, i don't think i used TestCase stuff that wasn't around in 2.6... but maybe.

theengineear · 2015-06-28T14:47:44Z

plotly/offline.py

+import requests
+
+
+def download_plotlyjs(download_url, plotlyjs_dir='~/.plotly/plotlyjs'):


Can we get rid of the download_url param and just create a streambed url that we know and can authenticate at?

Then, we can just write a function to decide whether the requesting user has access?

Additionally, why do we need the plotlyjs_dir arg? is there a good reason for folks to need to change this? Also, i think it's not used in the func?

(obviously, the download_url is perfect for the current dev though :))

Finally, if this didn't require any arguments, we could just call it the first time a user tries to use it, which would mean they don't need to know about it.

great idea, going to punt 👟 🏈 this one to a future release

theengineear · 2015-06-28T16:21:27Z

@chriddyp , playing around with this now, nice work!

theengineear · 2015-06-28T16:22:05Z

I noticed that when you open notebooks back up, nothing seems to run until the plot is drawn:

theengineear · 2015-06-28T16:23:35Z

that said, super cool that opening them backup just works

theengineear · 2015-06-28T16:29:49Z

nice! plot loads up in nbviewer, that's super solid!

http://nbviewer.ipython.org/gist/theengineear/3b986f62836453d470ea

chriddyp · 2015-06-29T21:46:14Z

bundle it up
test in old ipython notebook
~~investigate moving plotting calls to be async to make the notebook load quick~~
the empty notebook is waiting for the huge notebook to be served
test on windows
configure links for enterprise
better warning indicator if trying to call iplot before calling init_notebook_mode

v2

compress json
let download_plotlyjs authenticate and download without url

chriddyp · 2015-06-30T05:25:55Z

@etpinard - due to some conflicts in ipython 2.4.1, I'm going to bundle up plotly.js w/out jquery 1.8.3 and instead rely on ipython's 2.0.3 version of jquery.

here's the test suite on the different versions:

at first glance, versions look and interact the same

chriddyp · 2015-06-30T05:27:18Z

@etpinard try zooming on the 2dhistogram_contour_subplots example.. do you see the black background? (happens on all versions)

chriddyp · 2015-06-30T20:26:52Z

@theengineear nice tinkerbell! throwback!

follow suit of Crypto and py core team: pyca/cryptography@0857894

theengineear · 2015-07-01T03:45:01Z

Not opposed to adding ipython to core-tests, but, then we need to add it as a requirement in setup.py.

I'd suggest we go with ipython[all] or at least ipython[notebook].

I just did a quick search for ipython tests and it seems that there's some support out there for testing in a notebook: https://pypi.python.org/pypi/pytest-ipynb

I haven't really tried we might be able to test everything we need to outside of a notebook environment. Again, just haven't really tried.

chriddyp · 2015-07-01T18:47:23Z

yeah, nvm, I thought that the test_optional wasn't being run by circle... but it is! @theengineear - can I get a 💃 ?

theengineear · 2015-07-02T18:15:32Z

plotly/offline.py

+
+def download_plotlyjs(download_url):
+    if not os.path.exists(plotlyjs_path):
+        os.makedirs(plotlyjs_path)


can you check for write permissions and gracefully exit here? I think the tools.py module defines it:
https://github.com/plotly/python-api/blob/master/plotly/tools.py#L61-76

_file_permissions

theengineear · 2015-07-02T18:38:36Z

non-blocking, are we pushing this up to pypi though? i feel like we might want to just allow folks to download from github master for a bit?

👯

chriddyp · 2015-07-02T18:50:58Z

@theengineear - yeah, I'm gonna push it up to pypi as those openssl errors that bubbled up through the git+ install scares me.

theengineear · 2015-07-02T20:31:45Z

thx @chriddyp !

azarezade · 2015-07-03T10:53:55Z

Sorry if I ask trivial question
but how can I setup plotly with offline mode available?

Plotly Offline

chriddyp added 4 commits June 25, 2015 00:28

first pass at offline mode in plotlyjs

57ad872

version 1.7.0 - offline mode

3fca388

make offline.py importable

421f3ff

update python lib url

500c9ab

etpinard reviewed Jun 25, 2015
View reviewed changes

theengineear reviewed Jun 28, 2015
View reviewed changes

bundle it up!

096e36c

remove variable directory

45bec11

chriddyp added 3 commits June 30, 2015 16:50

💄

3e64b9c

rename the bundle

a47c761

export to enterprise; update link text the plotly.js way.

c653188

chriddyp added 4 commits June 30, 2015 17:42

refactor tests to handle core vs optional deps (ipython)

2793609

Depreciate support for Python 2.6

08a8660

follow suit of Crypto and py core team: pyca/cryptography@0857894

rm 2.6 reqs, too

770f601

wb for python 3.3

1552f8e

theengineear reviewed Jul 2, 2015
View reviewed changes

chriddyp added 3 commits July 2, 2015 14:58

TestCase for the :habit: hamster, this one's for you @theengineear

3d95463

narrower exception handling

ce5b42c

http://i.imgur.com/7y6JoyU.png

767d01c

chriddyp added 4 commits July 2, 2015 17:13

renaming now that module is mostly private

b6ef5fd

update directory of bundle for tests since protected

73114ff

fix conflicts

5ad5138

one more

e94e66c

fix tests

bb72482

chriddyp added a commit that referenced this pull request Jul 3, 2015

Merge pull request #236 from plotly/offline

2598650

Plotly Offline

chriddyp merged commit 2598650 into master Jul 3, 2015

nicolaskruchten deleted the offline branch June 19, 2020 16:09

		import requests


		def download_plotlyjs(download_url, plotlyjs_dir='~/.plotly/plotlyjs'):

Uh oh!

Plotly Offline #236

Plotly Offline #236

Uh oh!

Conversation

chriddyp commented Jun 25, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etpinard commented Jun 25, 2015

Uh oh!

chriddyp commented Jun 25, 2015

Uh oh!

chriddyp commented Jun 25, 2015

Uh oh!

theengineear commented Jun 26, 2015

Uh oh!

theengineear commented Jun 26, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theengineear commented Jun 28, 2015

Uh oh!

theengineear commented Jun 28, 2015

Uh oh!

theengineear commented Jun 28, 2015

Uh oh!

theengineear commented Jun 28, 2015

Uh oh!

chriddyp commented Jun 29, 2015

Uh oh!

chriddyp commented Jun 30, 2015

Uh oh!

chriddyp commented Jun 30, 2015

Uh oh!

chriddyp commented Jun 30, 2015

Uh oh!

theengineear commented Jul 1, 2015

Uh oh!

chriddyp commented Jul 1, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theengineear commented Jul 2, 2015

Uh oh!

chriddyp commented Jul 2, 2015

Uh oh!

theengineear commented Jul 2, 2015

Uh oh!

azarezade commented Jul 3, 2015

Uh oh!

Uh oh!