Skip to content

order fixups #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2020
Merged

order fixups #2491

merged 1 commit into from
May 22, 2020

Conversation

jdamiba
Copy link

@jdamiba jdamiba commented May 22, 2020

The purpose of this PR is to fixup the order of examples in the advanced_opt and chart_events sections.

@jdamiba jdamiba changed the title fixup order to be sequential order fixups May 22, 2020
@jdamiba jdamiba changed the base branch from master to doc-prod May 22, 2020 13:10
@jdamiba jdamiba requested a review from nicolaskruchten May 22, 2020 13:29
nicolaskruchten
nicolaskruchten approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@nicolaskruchten nicolaskruchten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 once tests are green

@nicolaskruchten nicolaskruchten merged commit a13d3fa into doc-prod May 22, 2020
@nicolaskruchten
Copy link
Contributor

ok they're green!

@jdamiba jdamiba deleted the order-fixup branch May 22, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nicolaskruchten nicolaskruchten nicolaskruchten approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdamiba @nicolaskruchten