Add scale param to images #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a user specifies ‘test.png’ as their filename, then don’t fuck with that! now, we were changing that to `’test.png.png’` if they also specified `format=‘png’`. sure, now they could set their filename `test.png` and their format `jpeg`, but that is their fault. this fixes the test, too.
| arg_string = ', '.join([str(a) for a in args]) | ||
| test_name = test_generator.__name__.replace('_generate', 'test') | ||
| test_name += '({})'.format(arg_string) | ||
| setattr(TestImage, test_name, _test) |
There was a problem hiding this comment.
this is so much fun.
autogenerating tests of all of the permutations of input arguments!
♡ nosetests plotly/tests/test_core/test_image/ --pdb -v
_test_image_get_returns_valid_image_test(jpeg, 300, 300, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(jpeg, 300, None, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(jpeg, None, 300, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(jpeg, None, None, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(pdf, 300, 300, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(pdf, 300, None, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(pdf, None, 300, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(pdf, None, None, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(png, 300, 300, 5) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(png, 300, 300, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(png, 300, None, 5) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(png, 300, None, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(png, None, 300, 5) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(png, None, 300, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(png, None, None, 5) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(png, None, None, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(svg, 300, 300, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(svg, 300, None, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(svg, None, 300, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
_test_image_get_returns_valid_image_test(svg, None, None, None) (plotly.tests.test_core.test_image.test_image.TestImage) ... ok
heck yeah setattr. this line assigns test functions to the test class which unique names that start with test_ and therefore are run by nose!
@BRONSOLO @theengineear - these endpoints return a 400 now? ``` test_duplicate_folders (plotly.tests.test_core.test_file.test_file.FolderAPITestCase) ... ERROR ====================================================================== ERROR: test_duplicate_folders (plotly.tests.test_core.test_file.test_file.FolderAPITestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/ubuntu/python-api/plotly/tests/test_core/test_file/test_file.py", line 45, in test_duplicate_folders py.file_ops.mkdirs(first_folder) File "/home/ubuntu/python-api/plotly/plotly/plotly.py", line 717, in mkdirs _api_v2.response_handler(res) File "/home/ubuntu/python-api/plotly/plotly/plotly.py", line 1171, in response_handler raise(plotly_exception) PlotlyRequestError: -------------------- >> begin captured logging << -------------------- requests.packages.urllib3.connectionpool: INFO: Starting new HTTPS connection (1): api.plot.ly requests.packages.urllib3.connectionpool: DEBUG: "POST /v2/folders HTTP/1.1" 400 69 --------------------- >> end captured logging << --------------------- ```
|
@chriddyp , yup, it'd be best to test that it's 4xx for now. |
|
this is sweet btw! 💃 |
|
👍 |
|
@theengineear @BRONSOLO - it's not supposed to be a 4xx though, it's supposed to be a 200! |
|
@chriddyp sorry read that too fast, looking into it now (#266 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check it @cldougl @aneda @theengineear @BRONSOLO