Skip to content

Dataframes have a to_string method! #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2015
Merged

Dataframes have a to_string method! #305

merged 2 commits into from
Sep 29, 2015

Conversation

theengineear
Copy link
Contributor

We try to use duck-typing here, but it doesn’t quite make sense.

@theengineear
Dataframes have a to_string method!
9bfe62e 
We try to use duck-typing here, but it doesn’t quite make sense.
@theengineear
Oops, it’d help to use the right value o__O
1e807d1
@theengineear
Copy link
Contributor Author

@etpinard | @chriddyp | @cldougl quickie :)

Anything that happens to define a to_string method will be used here, but since we pass arguments to to_string, that's almost always going to fail. This just checks that the val is the right instance instead of doing it by the EAFP Principle.

@chriddyp
Copy link
Member

💃

theengineear added a commit that referenced this pull request Sep 29, 2015
@theengineear
Merge pull request #305 from plotly/to-string-bug
a3381a5 
Dataframes have a `to_string` method!
@theengineear theengineear merged commit a3381a5 into master Sep 29, 2015
@theengineear theengineear deleted the to-string-bug branch September 29, 2015 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theengineear @chriddyp