Add a test to force us to update default schema! #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chriddyp @etpinard @cldougl I realized I was about to pip-push a broken version to PyPI because we recently changed the structure of I was just going to fix it and move on, but I think that's not a great solution, this keeps us a little more honest. Seem like a good idea? |
|
💃 good idea |
theengineear
added a commit
that referenced
this pull request
Sep 29, 2015
Add a test to force us to update default schema!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gah, we'll never ever do this if it doesn't error on circle. The failure prints out instructions to fix it... so maybe it won't even be confusing when our future selves encounter it? :)